review comments

open-traffic-generator · Dec 4, 2023 · db28e51 · db28e51
1 parent b52d7f5
commit db28e51
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 646 deletions.
diff --git a/artifacts/openapi.html b/artifacts/openapi.html
diff --git a/artifacts/openapi.yaml b/artifacts/openapi.yaml
diff --git a/artifacts/otg.proto b/artifacts/otg.proto
diff --git a/flow/packet-headers/snmpv2.yaml b/flow/packet-headers/snmpv2.yaml
@@ -3,6 +3,8 @@ components:
     Flow.Snmpv2:
       description: SNMPv2 packet header as defined in RFC3416.
       type: object
+      required:
+        - choice
       properties:
         choice:
           type: string
@@ -58,7 +60,6 @@ components:
                 Identifies a particular SNMP request. 
                 This index is echoed back in the response from the SNMP agent, 
                 allowing the SNMP manager to match an incoming response to the appropriate request. 
-                TBD: negative values should be allowed.
             format: integer
             length: 32
             default: 0
@@ -69,6 +70,7 @@ components:
           description: >-
             The SNMP agent places an error code in this field in the response message if an error occurred processing the request.
           type: string
+          default: no_error
           x-enum:
             no_error:
               x-field-uid: 1
@@ -148,15 +150,15 @@ components:
         non_repeaters:
           x-field-pattern:
             description: >-
-                Determines the number of variables in the variable list for which a simple get_next_request operation has to be done.
+                One variable binding in the Response-PDU is requested for the first non_repeaters variable bindings in the GetBulkRequest.
             format: integer
             length: 32
             default: 0
           x-field-uid: 2
         max_repetitions:
           x-field-pattern:
             description: >-
-                Indicates how many rows of the table are to be retrieved in a single GetBulk operation.
+                A maximum of max_repetitions variable bindings are requested in the Response-PDU for each of the remaining variable bindings in the GetBulkRequest after the non_repeaters variable bindings.
             format: integer
             length: 32
             default: 0
@@ -203,20 +205,23 @@ components:
       properties:
         choice:
           type: string
+          default: no_value
           x-field-uid: 1
           x-enum:
-            ip_address:
+            no_value:
               x-field-uid: 1
-            counter:
+            ip_address:
               x-field-uid: 2
-            timeticks:
+            counter:
               x-field-uid: 3
-            arbitrary:
+            timeticks:
               x-field-uid: 4
-            big_counter:
+            arbitrary:
               x-field-uid: 5
-            unsigned_integer:
+            big_counter:
               x-field-uid: 6
+            unsigned_integer:
+              x-field-uid: 7
         ip_address:
           $ref: '#/components/schemas/Flow.Snmpv2.VariableBindingIPValue'
           x-field-uid: 2
@@ -262,6 +267,7 @@ components:
       properties:
         choice:
           type: string
+          default: ipv4
           x-field-uid: 1
           x-enum:
             ipv4: