Fix CI to verify chart installing on test-namespace #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ambiguity for `default` and `test-namespace`. It comes from `namespaceOverride` after #122. This commit helps to complete `namespaceOverride`. - create `test-namespace` namespace - install app on `test-namespace` namespace instead of `default` - (Optional) wait until `pod/open-webui-0` is ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opinion
Hello, folks. To resolve #124, we should remove the ambiguity between
defaultandtest-namespace, which stems from thenamespaceOverrideintroduced in #122. This commit ensures proper completion ofnamespaceOverride. Proposed changes are followings:test-namespacenamespace.test-namespacenamespace instead of thedefaultnamespace.kubectl waitto ensurepod/open-webui-0is ready before proceeding.And local test is following:
All resources became ready except
open-webui-ollama-test-connection. That pod would be 'Completed' when recreated so we can ignore it.If you think that using
kubectl waitmight cause delays or unintended lags, please let me know.Copilot Summary
This pull request includes changes to the
.github/workflows/helm-test-open-webui.ymlfile to enhance the deployment process for theopen-webui. The most important changes include creating a new namespace, applying the configuration within that namespace, and ensuring the pod is ready before proceeding.Deployment process improvements:
.github/workflows/helm-test-open-webui.yml: Added commands to create atest-namespace, apply theopen-webui.yamlconfiguration within this namespace, and wait for theopen-webui-0pod to be ready with a timeout of 600 seconds.