Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/setup configuration #131

Merged
merged 12 commits into from
Apr 2, 2024
Merged

Feature/setup configuration #131

merged 12 commits into from
Apr 2, 2024

Conversation

annashamray
Copy link
Contributor

@annashamray annashamray commented Feb 26, 2024

@annashamray annashamray marked this pull request as draft February 26, 2024 10:54
@annashamray annashamray force-pushed the feature/setup-configuration branch from 722ce93 to 8bf9abb Compare February 28, 2024 16:09
@annashamray annashamray marked this pull request as ready for review February 29, 2024 09:50
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 96.46643% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 90.61%. Comparing base (9df35b5) to head (ff42130).

Files Patch % Lines
src/nrc/config/authorization.py 88.23% 4 Missing and 2 partials ⚠️
src/nrc/utils/__init__.py 71.42% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   89.90%   90.61%   +0.70%     
==========================================
  Files          82       86       +4     
  Lines        2011     2237     +226     
  Branches      232      251      +19     
==========================================
+ Hits         1808     2027     +219     
- Misses        179      183       +4     
- Partials       24       27       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annashamray annashamray requested a review from stevenbal March 14, 2024 14:17
Dockerfile Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docs/installation/configuration/env_config.md Show resolved Hide resolved
docs/installation/configuration/opennotifs_config_cli.rst Outdated Show resolved Hide resolved
docs/installation/configuration/opennotifs_config_cli.rst Outdated Show resolved Hide resolved
requirements/base.in Outdated Show resolved Hide resolved
src/nrc/config/authorization.py Outdated Show resolved Hide resolved
@annashamray annashamray force-pushed the feature/setup-configuration branch from ff42130 to 5f4e57c Compare April 2, 2024 13:49
@annashamray annashamray merged commit 8f5516c into main Apr 2, 2024
13 checks passed
@annashamray annashamray deleted the feature/setup-configuration branch April 2, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants