Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate log-smoothing to mini-library #505

Open
gfudenberg opened this issue Mar 4, 2024 · 2 comments
Open

migrate log-smoothing to mini-library #505

gfudenberg opened this issue Mar 4, 2024 · 2 comments

Comments

@gfudenberg
Copy link
Member

proposal:
migrate log-smoothing code to a mini repository.

why?

  • cooltools, pairtools, and polykit all need smoothing of contacts vs. distance but shouldn't be each other's dependencies.
  • each repository might have different desired presets for column names

design questions:
-- operate on numpy arrays or some dataFrame with sensible present column names.
-- argument in favor of operating on dataFrames: There is shared boilerplate for smoothing data in a DataFrame.

@golobor
Copy link
Member

golobor commented Mar 5, 2024

i wonder if we could consider expanding this proposal to migrate all application-agnostic numerical procedures (i.e. https://github.com/open2c/cooltools/blob/master/cooltools/lib/numutils.py ) into a separate library.
Ofc, I know that we went through many iterations of such a library and there've been times when we though that it's messy and undesirable. However, I think, we can make this library clean and tidy if it were to contain only generic numeric routines and not library-specific codes. Thoughts?..

@Phlya
Copy link
Member

Phlya commented Mar 5, 2024

I am not super keen on a "library" that is a random collection of unrelated functions... But we can discuss how it could make sense, i.e. for functions that are actually useful across other libraries, or if they use each other, or something like that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants