Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synchronize CLI and API defaults for get_expected_cis smoothing & aggregation #506

Open
gfudenberg opened this issue Mar 4, 2024 · 0 comments
Open

synchronize CLI and API defaults for get_expected_cis smoothing & aggregation #506

gfudenberg opened this issue Mar 4, 2024 · 0 comments
Labels
enhancement

Comments

@gfudenberg
Copy link
Member

cooltools/cooltools/cli/expected_cis.py

Line 46 in ba2be42

@click.option(

issue: currently API returns smoothed & aggregated by default, but CLI does not.
proposal: CLI should smooth and aggregate across regions by default.

After addressing this issue, a release should follow, since this may change default pipeline outputs.

Notes:

  • is smooth_sigma=0.1 a reasonable default? @golobor has a favorite of 0.03.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gfudenberg