Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first diagonal NaNs for smoothed expected_cis #509

Open
gfudenberg opened this issue Mar 11, 2024 · 0 comments
Open

first diagonal NaNs for smoothed expected_cis #509

gfudenberg opened this issue Mar 11, 2024 · 0 comments

Comments

@gfudenberg
Copy link
Member

gfudenberg commented Mar 11, 2024

the first two diagonals of a contact map are often avoided for technical reasons. Default smoothing, however, does not propagate this to the .smoothed columns. We currently manually undo this in documentation, but this should probably be done by expected_cis by default (and then notebooks can be updated).

image

A previous (un-merged) PR had suggested:

# propagate nan
, but this would need to be modified after the API updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant