Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes after running the Archie validator on the current BMM models #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes after running the Archie validator on the current BMM models #17

wants to merge 2 commits into from

Conversation

pieterbos
Copy link
Contributor

@pieterbos pieterbos commented Nov 23, 2022 •
edited
Loading

I ran the Archie BMM validator on these files. It showed a couple of problems. This pull request fixes most of them. The problems:

  • references to a generic type as if they were a simple type (currently not allowed by the Archie validator - or should it be?)
  • ARCHETYPE_HRID was still present in the class list of packages, although it was removed
  • RESOURCE_DESCRIPTION.details in base 1.1.0 is a generic property now, but still had a cardinality field that should not be present
  • OBJECT_REF.namespace was marked optional in version 1.1.0 of base. It is mandatory in the specification (and also in Archie)

In addition, one more error is present that I cannot fix:

  • in task planning 1.6.0, EVENT is defined. However, in one of the includes, also EVENT is defined. Since currently BMM validates the uniqueness of class names, to be able to use them in Archetypes without a package reference, this fails validation in Archie. However, both the specification and the BMM define this EVENT class - so how to handle this?

@neoehr
Copy link

neoehr commented Nov 23, 2022

https://discourse.openehr.org/t/event-found-in-task-planning-and-rm/2027

pieterbos added a commit to openEHR/archie that referenced this pull request Nov 23, 2022
@pieterbos
Add latest (fixed) bmms from specifications-ITS-BMM (openEHR/specific…
0a34707 
…ations-ITS-BMM#17)
@pieterbos pieterbos mentioned this pull request Nov 23, 2022
Merged
31 tasks
pieterbos added a commit to openEHR/archie that referenced this pull request Jan 31, 2023
@pieterbos
Update BMMs to latest version + json schema improvements (#459)
25a2c9d 
* Add latest (fixed) bmms from specifications-ITS-BMM (openEHR/specifications-ITS-BMM#17)

* Improve validation message to show enclosing class when creating a simple type results in an error

* Remove Nullable from ACTIVITY.action_archetype_id, it should not be there according to specification

* Add root types/entry points to json schema

* update archie version in json schema generator

* Add option to ignore attributes in json schema, plus ignore DV_QUANTITY.property

* Fix hashes in json schema - map to additionalProperties

* Fix DV_URI/DV_EHR_URI value not being required

* Correctly replace Uri in BMM with a string with uri-reference format in Json Schema

* Fix test - this BMM update actually removes some known differences between Archie and the BMM

* Update to most recent BMMs

* Split Json Schema creator in a generic one and a openEHR-specific one, ignore extra classes

* Mark RESOURCE_DESCRIPTION.original_publisher as not mandatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterbos @neoehr