-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable footnote backlinks in Markdown #1490
Conversation
These backlinks don't work reliably and are thus more harmful than useful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 92.46% 92.64% +0.18%
==========================================
Files 103 106 +3
Lines 2442 2503 +61
==========================================
+ Hits 2258 2319 +61
Misses 184 184 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing locally, this does not fix the problem you described in #1452. The converted HTML still contains class attributes. Is this expected?
Yes, that's expected. However, if you disable the new option, another link after the footnote is added, which further contains another We are talking about two different things here: HTML: This PR removes the ↩ link Source Code: It only tackles the element with the My comment in #1452 is about the element with As you can see, the reverse footnote is added with an href anchor. However, Since the counterpart is not added as ID to some text, it won't work (or I don't know how it should). The issue with the footnote itself still exists and is open. |
@Mathis-Z What's the current status here? Are you fine with the changes I proposed (and see a change locally) or do you still have concerns? |
Yes, I am fine with your changes 👍 |
These backlinks don't work reliably and are thus more harmful than useful.