Migrate to Solid Queue 0.9.x, extract tables, and update config #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSerth
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1652 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 133 133
Lines 3338 3338
=======================================
Hits 3164 3164
Misses 174 174 ☔ View full report in Codecov by Sentry. |
MrSerth
force-pushed
the
solid_queue
branch
2 times, most recently
from
02ae4c6
to
b71c250
Compare
MrSerth
changed the title
MrSerth
force-pushed
the
solid_queue
branch
from
72da921
to
e3f8a0b
Compare
MrSerth
force-pushed
the
solid_queue
branch
from
e3f8a0b
to
ccf8929
Compare
Dome-GER
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
The db:prepare change could have received a note in the PR description. ;) Thanks for the verbal explanation today (the first case switching to a setup with multiple DBs where DB prepare is the suitable command, loading the schema or seeding the DB and your change with not executing seeds if users exist).
With Solid Queue 0.8.0, support for dedicated databases were introduced. In fact, Rails recommends moving the database, which we perform with the migration. Unfortunately, it is currently unclear how exactly schema migrations will be provided. Therefore, we cannot use the same GitHub actions workflow for now and will re-add it once a new migration has been published.
With Solid Queue 0.9.0, the configuration is split into two files (`queue.yml` and `recurring.yml`)
We currently lack valid credentials to push changes, so that we don't want to execute the job regularly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Solid Queue 0.8.0, support for dedicated databases were introduced. In fact, Rails recommends moving the database, which we perform with the migration.
Unfortunately, it is currently unclear how exactly schema migrations will be provided. Therefore, we cannot use the same GitHub actions workflow for now and will re-add it once a new migration has been published.
With Solid Queue 0.9.0, the configuration is split into two files (
queue.ymlandrecurring.yml)