Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Solid Queue 0.9.x, extract tables, and update config #1652

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

MrSerth
Copy link
Member

@MrSerth MrSerth commented Sep 10, 2024

With Solid Queue 0.8.0, support for dedicated databases were introduced. In fact, Rails recommends moving the database, which we perform with the migration.

Unfortunately, it is currently unclear how exactly schema migrations will be provided. Therefore, we cannot use the same GitHub actions workflow for now and will re-add it once a new migration has been published.


With Solid Queue 0.9.0, the configuration is split into two files (queue.yml and recurring.yml)

@MrSerth MrSerth added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Sep 10, 2024
@MrSerth MrSerth self-assigned this Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.78%. Comparing base (72ee3d6) to head (fefb945).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1652   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         133      133           
  Lines        3338     3338           
=======================================
  Hits         3164     3164           
  Misses        174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrSerth MrSerth force-pushed the solid_queue branch 2 times, most recently from 02ae4c6 to b71c250 Compare September 11, 2024 10:11
@MrSerth MrSerth changed the title Migrate to Solid Queue 0.8.x and extract tables Migrate to Solid Queue 0.9.x, extract tables, and update config Sep 11, 2024
Copy link
Member

@Dome-GER Dome-GER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The db:prepare change could have received a note in the PR description. ;) Thanks for the verbal explanation today (the first case switching to a setup with multiple DBs where DB prepare is the suitable command, loading the schema or seeding the DB and your change with not executing seeds if users exist).

With Solid Queue 0.8.0, support for dedicated  databases were introduced. In fact, Rails recommends moving the database, which we perform with the migration.

Unfortunately, it is currently unclear how exactly schema migrations will be provided. Therefore, we cannot use the same GitHub actions workflow for now and will re-add it once a new migration has been published.
With Solid Queue 0.9.0, the configuration is split into two files (`queue.yml` and `recurring.yml`)
We currently lack valid credentials to push changes, so that we don't want to execute the job regularly.
@MrSerth MrSerth merged commit c743b91 into master Oct 15, 2024
11 checks passed
@MrSerth MrSerth deleted the solid_queue branch October 15, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants