Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium: Refactor WaitFor* scripts to prevent crashes #1718

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

MrSerth
Copy link
Member

@MrSerth MrSerth commented Oct 11, 2024

The previously used approach with Timeout.timeout works. However, it might interrupt the page.evaluate_script, which will cause an unhandled exception with the Selenium webdriver which in turn crashes. Once crashed, all further Selenium-based tests will fail, too.

The previously used approach with `Timeout.timeout` works. However, it might interrupt the `page.evaluate_script`, which will cause an unhandled exception with the Selenium webdriver which in turn crashes. Once crashed, all further Selenium-based tests will fail, too.
@MrSerth MrSerth added bug ruby Pull requests that update Ruby code labels Oct 11, 2024
@MrSerth MrSerth requested a review from Dome-GER October 11, 2024 21:47
@MrSerth MrSerth self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (1147a89) to head (8465436).
Report is 23 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1718   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         130      130           
  Lines        3330     3330           
=======================================
  Hits         3156     3156           
  Misses        174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dome-GER Dome-GER merged commit 72ee3d6 into master Oct 15, 2024
9 checks passed
@Dome-GER Dome-GER deleted the selenium_wait_for branch October 15, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants