Cobbler: Replace SSH with XML-RPC API calls #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchoolGuy
force-pushed
the
feature/switch-to-xmlrpc
branch
from
6661712 to
b13d5ad
Compare
|
During fixing the unit tests an issue appeared. If the Cobbler Daemon is started in the foreground it listens on localhost to port 25151 for XML-RPC requests. This however doesn't include the HTTP API and furthermore ignores requests that are not done via localhost. Since in the test container, no nginx/apache is started the requests from Orthos are not being answered. |
|
Now the errors are coming from Django 5 in openSUSE Tumbleweed. |
SchoolGuy
force-pushed
the
feature/switch-to-xmlrpc
branch
from
e00b117 to
6d8ff7d
Compare
|
The PR is now in a reviewable state. All above mentioned issues have been taken care of. |
|
Since @ByteOtter will be part of the Orthos 2 reviewer team in the future I will count his review as a full one. His application to join the GitHub Team is already in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255
This PR aims to switch from SSH-based command execution for Cobbler to a more robust XML-RPC command execution.
Due to dependency updates in openSUSE Tumbleweed, this PR also adds support for Django 5.0 and later.
Advantages:
Open points:
get_<item type>()can't return unsaved items cobbler/cobbler#3799 so we can correctly handle the kernel options of unsaved items.