remove bogus attempt to lock cscreenrc

[olafhering]

touch(1) can not be used to lock a resource.

[olafhering]

In case locking can not be implemented in execute, a poor-mans-lock could be done with until mkdir $lockdir ;do sleep 1;done and rmdir $lockdir.

$lockdir could be /run/cscreen/cscreenrc.lock.

[SchoolGuy]

For a daemon like Orthos having something like SSH needed is an error in itself. As such I have no issue removing this part of the code without a replacement in execute.

[SchoolGuy]

@olafhering Do you consider this PR ready to be merged?

[olafhering]

Some locking is needed. I changed a dozen machines, and ended up with an cscreenrc which just contained the ORTHOS section. Apparently there are competing tasks, even if each machine is updated with enough time in between.

[SchoolGuy]

This is why I proposed to move this problem into a microservice running on the cscreen server. This fits more with the sidecar approach that would work better in the container world.

See #260 for my proposal.

[olafhering]

Yes, I have seen this. I think this PR is ready.

[SchoolGuy]

If you have your GPG key at hand I would appreciate a sign and force push.

[olafhering]

0e4686a is signed AFAICS, just GH does not recognize it after force push.

[SchoolGuy]

Ah you didn't upload your public key to GitHub.

[olafhering]

It is uploaded, just GH is not entirely happy with it.