Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flake8-black and pylint for consistency #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use flake8-black and pylint for consistency #148

wants to merge 1 commit into from

Conversation

kalikiana
Copy link
Member

@kalikiana kalikiana commented Oct 18, 2023 •
edited
Loading

The plugins combines both, meaning users only need to use one command to check both (or use make checkstyle).

@kalikiana kalikiana mentioned this pull request Oct 18, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023

This pull request is now in conflicts. Could you fix it? 🙏

@okurz
Copy link
Member

okurz commented Oct 18, 2023

After #147 I still think this is a good idea. Please rebase

@okurz
Copy link
Member

okurz commented Oct 19, 2023

+1

@kalikiana kalikiana marked this pull request as ready for review October 20, 2023 00:14
@okurz
Copy link
Member

okurz commented Oct 30, 2023

Can you verify that https://github.com/openSUSE/qem-bot/actions/runs/6577795142/job/17870196696?pr=148#step:6:12 actually does all the previous checks? The line looks so innocent :)

@kalikiana kalikiana changed the title Use flake8-black to benefit from more style check Use flake8-black and pylint for consistency Oct 30, 2023
@kalikiana
Copy link
Member Author

Can you verify that https://github.com/openSUSE/qem-bot/actions/runs/6577795142/job/17870196696?pr=148#step:6:12 actually does all the previous checks? The line looks so innocent :)

Run make checkstyle
flake8 ./openqabot pc_helper_online.py --config=setup.cfg
./openqabot/approver.py:36:1: BLK100 Black would make changes.
./openqabot/approver.py:42:5: E303 too many blank lines (6)
./openqabot/types/incidents.py:79:5: PLR9[11](https://github.com/openSUSE/qem-bot/actions/runs/6692884016/job/18182952989?pr=148#step:6:12) Too many return statements ([13](https://github.com/openSUSE/qem-bot/actions/runs/6692884016/job/18182952989?pr=148#step:6:14)/6) (too-many-return-statements)
pc_helper_online.py:11:4: E271 multiple spaces after keyword
pc_helper_online.py:11:5: BLK100 Black would make changes.
pc_helper_online.py:11:[14](https://github.com/openSUSE/qem-bot/actions/runs/6692884016/job/18182952989?pr=148#step:6:15): E211 whitespace before '('
pc_helper_online.py:11:35: E203 whitespace before ':'
pc_helper_online.py:11:37: PLC303 Trailing whitespace (trailing-whitespace)
pc_helper_online.py:11:37: W291 trailing whitespace
make: *** [Makefile:14: flake8] Error 1
Error: Process completed with exit code 2.

https://github.com/openSUSE/qem-bot/actions/runs/6692884016/job/18182952989?pr=148

@okurz
Copy link
Member

okurz commented Nov 3, 2023

looks good. You can revert the on-purpose mistakes again :)

@kalikiana
Use flake8-black and pylint for consistency
ec7e000 
The plugins combine the checks, meaning users only need to
use one command for everything (or use make checkstyle).
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 8, 2024

This pull request is now in conflicts. Could you fix it? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okurz okurz okurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalikiana @okurz