Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flake8-black and pylint for consistency #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use flake8-black and pylint for consistency #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,10 @@ all:
only-test:
python3 -m pytest

.PHONY: black
black:
black --check ./

.PHONY: tidy
tidy:
black ./

.PHONY: pylint
pylint:
pylint ./openqabot pc_helper_online.py --rcfile=pylintrc

.PHONY: flake8
flake8:
flake8 ./openqabot pc_helper_online.py --config=setup.cfg
Expand All @@ -27,11 +19,8 @@ test-with-coverage:

# aggregate targets

.PHONY: lint
lint: pylint flake8

.PHONY: checkstyle
checkstyle: black lint
checkstyle: flake8

.PHONY: test
test: only-test checkstyle
5 changes: 2 additions & 3 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ requests
osc
openqa-client
ruamel.yaml
black
jsonschema
urllib3<2 # responses needs <2, see https://github.com/getsentry/responses/issues/635
pylint
flake8
flake8-black
flake8-pylint
Loading