-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process all relevant jobs from openQA #170
base: master
Are you sure you want to change the base?
Conversation
daa9c66
to
956d485
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But @kraih can you judge about the impact of retrieving and storing more information from openQA into qem-dashboard?
@Mergifyio rebase |
As discussed in slack -> https://suse.slack.com/archives/C02CANHLANP/p1709109430256279 this change forces bot process and sync all results, not only latest. for example: with latest: for r in ret: print(f"{r['id']}: .... {r['result']}") ... 13580193: .... softfailed 13580199: .... softfailed 13618826: .... passed without latest: >>> for r in ret: print(f"{r['id']}: .... {r['result']}") ... 13392313: .... failed 13392314: .... failed 13392315: .... failed 13534621: .... passed 13534659: .... failed 13535630: .... failed 13535631: .... failed 13556841: .... user_cancelled 13574056: .... failed 13574057: .... failed 13574058: .... failed 13580193: .... softfailed 13580199: .... softfailed 13580851: .... softfailed 13601665: .... failed 13602658: .... failed 13604911: .... failed 13606694: .... failed 13618826: .... passed >>>
✅ Branch has been successfully rebased |
Hard to say, short term probably no impact. We already have 2.039.238 jobs in the dashboard database. This will accelerate our need to implement functionality for cleaning up old openQA jobs though. That does not exist yet and we are currently keeping job data indefinitely. |
With that, can we remove the "no ready" label? |
Small update on this. We do depend on an Specifically the code here updates the timestamp every time. If an older job ends up getting the newest timestamp, we will run into ordering issues. |
So what's your suggestion. Should this prevent us from accepting this PR? |
This should probably be double checked before the PR is accepted, yes. |
As discussed in slack ->
https://suse.slack.com/archives/C02CANHLANP/p1709109430256279
this change forces bot process and sync all results, not only latest.
for example:
with latest:
without latest: