Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process all relevant jobs from openQA #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mimi1vx
Copy link
Member

@mimi1vx mimi1vx commented Feb 28, 2024

As discussed in slack ->
https://suse.slack.com/archives/C02CANHLANP/p1709109430256279

this change forces bot process and sync all results, not only latest.

for example:
with latest:

for r in ret: print(f"{r['id']}: .... {r['result']}")
    ...
    13580193: .... softfailed
    13580199: .... softfailed
    13618826: .... passed

without latest:

 >>> for r in ret: print(f"{r['id']}: .... {r['result']}")
   ...
   13392313: .... failed
   13392314: .... failed
   13392315: .... failed
   13534621: .... passed
   13534659: .... failed
   13535630: .... failed
   13535631: .... failed
   13556841: .... user_cancelled
   13574056: .... failed
   13574057: .... failed
   13574058: .... failed
   13580193: .... softfailed
   13580199: .... softfailed
   13580851: .... softfailed
   13601665: .... failed
   13602658: .... failed
   13604911: .... failed
   13606694: .... failed
   13618826: .... passed
   >>>

@mimi1vx mimi1vx marked this pull request as draft February 28, 2024 12:30
@mimi1vx mimi1vx marked this pull request as ready for review February 28, 2024 12:50
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But @kraih can you judge about the impact of retrieving and storing more information from openQA into qem-dashboard?

@okurz
Copy link
Member

okurz commented Feb 28, 2024

@Mergifyio rebase

As discussed in slack ->
https://suse.slack.com/archives/C02CANHLANP/p1709109430256279

this change forces bot process and sync all results, not only latest.

for example:
  with latest:
     for r in ret: print(f"{r['id']}: .... {r['result']}")
       ...
       13580193: .... softfailed
       13580199: .... softfailed
       13618826: .... passed

  without latest:
     >>> for r in ret: print(f"{r['id']}: .... {r['result']}")
     ...
     13392313: .... failed
     13392314: .... failed
     13392315: .... failed
     13534621: .... passed
     13534659: .... failed
     13535630: .... failed
     13535631: .... failed
     13556841: .... user_cancelled
     13574056: .... failed
     13574057: .... failed
     13574058: .... failed
     13580193: .... softfailed
     13580199: .... softfailed
     13580851: .... softfailed
     13601665: .... failed
     13602658: .... failed
     13604911: .... failed
     13606694: .... failed
     13618826: .... passed
     >>>
Copy link
Contributor

mergify bot commented Feb 28, 2024

rebase

✅ Branch has been successfully rebased

@kraih
Copy link
Member

kraih commented Feb 29, 2024

But @kraih can you judge about the impact of retrieving and storing more information from openQA into qem-dashboard?

Hard to say, short term probably no impact. We already have 2.039.238 jobs in the dashboard database. This will accelerate our need to implement functionality for cleaning up old openQA jobs though. That does not exist yet and we are currently keeping job data indefinitely.

@Martchus
Copy link
Contributor

With that, can we remove the "no ready" label?

@kraih
Copy link
Member

kraih commented Feb 29, 2024

Hard to say, short term probably no impact.

Small update on this. We do depend on an updated timestamp in some places to pick the latest job. If there are any ordering issues with how updates are submitted to the dashboard, i could see this become an issue and the wrong job getting selected.

Specifically the code here updates the timestamp every time. If an older job ends up getting the newest timestamp, we will run into ordering issues.

@okurz
Copy link
Member

okurz commented Feb 29, 2024

Hard to say, short term probably no impact.

Small update on this. We do depend on an updated timestamp in some places to pick the latest job. [...]

So what's your suggestion. Should this prevent us from accepting this PR?

@kraih
Copy link
Member

kraih commented Feb 29, 2024

So what's your suggestion. Should this prevent us from accepting this PR?

This should probably be double checked before the PR is accepted, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants