From e45544c1834d88a5c77fbe32fea4b9cac67510f7 Mon Sep 17 00:00:00 2001
From: Lukas Panhorst <lukbelter@openbase.org>
Date: Thu, 11 Apr 2024 19:58:59 +0200
Subject: [PATCH] cleaning up workflow

---
 .github/workflows/build-and-test.yml | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
index 61f9d4499..3c6a01400 100644
--- a/.github/workflows/build-and-test.yml
+++ b/.github/workflows/build-and-test.yml
@@ -30,12 +30,12 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          changed_files=$(gh pr diff --name-only ${{ github.event.pull_request.number }})
+          changed_files=$(gh pr diff --name-only ${{ github.event.pull_request.number }}) #todo: Maybe change to git diff to avoid 300 diff limit?
           
           test=false
           for file in $changed_files; do
             if [[ $file == ".github/"* || $file == "doc/"* ]]; then
-              echo "$test file: $file"
+              # echo "$test file: $file"
             else
               test=true
               echo "$test file: $file"
@@ -56,8 +56,7 @@ jobs:
     if: |
       (github.event.pull_request.draft == false)
       && (needs.check.outputs.worth_testing == true)
-
-    
+   
     runs-on: ubuntu-latest
 
     steps:
@@ -93,13 +92,11 @@ jobs:
   test:
     name: "Test"
     timeout-minutes: 120
-
+    needs: build
     if: |
       (github.event.pull_request.draft == false)
       && (needs.check.outputs.worth_testing == true)
 
-    needs: build
-
     runs-on: ubuntu-latest
 
     steps: