Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task3: Georgiafab #564

Merged
merged 4 commits into from
Jul 4, 2024
Merged

task3: Georgiafab #564

merged 4 commits into from
Jul 4, 2024

Conversation

Georgiafab
Copy link
Collaborator

  1. 部署在 Sepolia 测试网上
    deploy
  2. 提交全部合约文件（ERC20、ERC721、NFTMarket）
    在 contract 文件夹中，其他文件用来测试的，忽略掉
  3. 提交上架 NFT、购买 NFT 的交易哈希
    提交上架 NFT： 0x754e73598b6b0059510532a5b53dd6068dcd81ac3a7cdf9d2ed5d06b1662562d
    购买 NFT： 0xf937159ae007f8de3cd163752d66b33a8ad8897926f8e619c9b436c689d864e0

linghuccc
linghuccc requested changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@linghuccc linghuccc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task3 只需要提交最主要的 3 份合约文件和上架NFT、购买NFT的交易哈希，请不要提交其他无关文件，谢谢

linghuccc
linghuccc requested changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@linghuccc linghuccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你写的 NFT 交易市场，只能交易一种 NFT，虽然在 list NFT 的时候，让 User 填 nft contract address，但如果填其他 nft 合约地址，只会出错。

请参考其他同学合约，谢谢。

linghuccc
linghuccc requested changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@linghuccc linghuccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上架 NFT 的哈希写成了 Mint ERC20 的哈希，请修改，谢谢

@linghuccc linghuccc merged commit 7084cd6 into openbuildxyz:main Jul 4, 2024
@linghuccc linghuccc self-assigned this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linghuccc linghuccc linghuccc approved these changes

Assignees

@linghuccc linghuccc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Georgiafab @linghuccc