Private harbor fix #711
Merged
Private harbor fix #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmajor
requested changes
Oct 15, 2024
deployment/helm/skaha/desktop-template/start-software-sh.template
Outdated
Show resolved
Hide resolved
deployment/helm/skaha/desktop-template/start-software-sh.template
Outdated
Show resolved
Hide resolved
skaha/src/main/java/org/opencadc/skaha/registry/ImageRegistryAuth.java
Outdated
Show resolved
Hide resolved
skaha/src/main/java/org/opencadc/skaha/utils/CommandExecutioner.java
Outdated
Show resolved
Hide resolved
|
@shinybrar Could you please take a look at this PR as well? |
shinybrar
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Keep in mind,
- I have no Java Background
- These are big classes of code to get lost in
Comments
- We could use
StandardCharsets.UTF_8explicitly when converting between byte arrays and strings for encoding and decoding. - There is one edgecase which still goes unchecked when the user provides a valid registry server, valid registry credentials, but malformed image/tag names for private images. This will lead to a 200 for the user, but the job will fail to launch. After discussions with @at88mph -- this is a known edgecase, which is currently bound by the limitation of our system.
- Since we perform kubectl bash command underneath the hood, the sting stream created in
CommandExecutionercan create an escape scenario, if the client secret has a escape character in the secret. - We should add unittests for the new code added
skaha/src/main/java/org/opencadc/skaha/registry/ImageRegistryAuth.java
Outdated
Show resolved
Hide resolved
|
@at88mph @shinybrar - Does the removal of the "headless" type affect the behaviour of the API at all? |
…nto private-harbor-fix
…nto private-harbor-fix
…nto private-harbor-fix
…nto private-harbor-fix
…nto private-harbor-fix
…nto private-harbor-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to specify
x-skaha-registry-authto request header in formatbase64Encode(username:secret).Cleanup for Checkstyle
Added to Desktop and passed to Desktop App