Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private harbor rework #728

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Private harbor rework #728

merged 4 commits into from
Nov 14, 2024

Conversation

at88mph
Copy link
Member

@at88mph at88mph commented Nov 14, 2024

  • Rename registryXXX to repositoryXXX to differentiate with IVOA Registry
  • Add default tab labels in the Portal
  • Remove extra clientSecret configuration (bug)
  • Expose /repository endpoint to obtain repository hosts

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.61%. Comparing base (f94016c) to head (65df2fb).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #728      +/-   ##
============================================
+ Coverage     18.32%   18.61%   +0.28%     
- Complexity      100      102       +2     
============================================
  Files            21       22       +1     
  Lines          1948     1961      +13     
  Branches        270      270              
============================================
+ Hits            357      365       +8     
- Misses         1539     1544       +5     
  Partials         52       52              
Flag Coverage Δ
skaha-unittests-coverage 18.61% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@shinybrar shinybrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the OpenAPI docs, change has been made. This looks ready to merge.

skaha/src/main/webapp/service.yaml Outdated Show resolved Hide resolved
@at88mph at88mph merged commit a832399 into opencadc:main Nov 14, 2024
5 checks passed
@at88mph at88mph deleted the private-harbor-rework branch November 14, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants