Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/intial-v initial code #1

Merged
merged 62 commits into from
Jun 19, 2024
Merged

feat/intial-v initial code #1

merged 62 commits into from
Jun 19, 2024

Conversation

hminaee-tc
Copy link
Contributor

@hminaee-tc hminaee-tc commented Jun 12, 2024

Changes proposed in this PR:

  1. Initial code for pre-commit hooks

  2. git work flow to also publish it as a PYPI

  3. extra cautionary pre commit hook to check the published version and complain if already exists

    • fail on existing v
    • fail on not committed toml file if v has changed
  4. E2E

  5. OIDC

  6. unit test

  7. Extra features

    • verbose
    • log-level
    • h
    • usage
    • dry-run
  • Pre commit for find and replace
    image

Pre commit checking if python already published or not
image

After bumping the version
image

image

After bumping and committing
image

E2E tests
image

dry run with logging

image

image

Copy link
Contributor

@andreouellet andreouellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hminaee-tc hminaee-tc requested review from hmdevelopermind and removed request for hmdevelopermind June 19, 2024 20:13
@hminaee-tc hminaee-tc merged commit 7401c8a into main Jun 19, 2024
4 checks passed
@hminaee-tc hminaee-tc deleted the feat/intial-v branch June 19, 2024 20:16
@andreouellet andreouellet restored the feat/intial-v branch June 19, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants