Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCDID Update #351

Closed
wants to merge 11 commits into from
Closed

OCDID Update #351

wants to merge 11 commits into from

Conversation

GoogleCivics-Kantar
Copy link
Contributor

@GoogleCivics-Kantar GoogleCivics-Kantar commented Oct 3, 2023

Hi Zohour,

This Pull Request contains below updated files for Bangladesh,

1.Added Bangladesh constituencies in top_level.csv
2.Added Bangladesh new constituencies in country-bd.csv

Copy link
Contributor

@evannjw evannjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go in a new file, maybe identifiers/country-bd/electoral_districts.csv. Also include a source in the PR, these districts look like they line up with https://en.wikipedia.org/wiki/List_of_constituencies_of_the_Jatiya_Sangsad

@@ -1,2 +1,302 @@
id,name
ocd-division/country:bd,Bangladesh
ocd-division/country:bd/cd:dhaka_1,Dhaka-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing cd to ed (electoral district) since it's more general. ex. cd:dhaka_1 -> ed:dhaka_1

@azuser
Copy link
Contributor

azuser commented Oct 4, 2023

Hi Zohour,

This Pull Request contains below updated files for Bangladesh,

1.Added Bangladesh constituencies in top_level.csv 2.Added Bangladesh new constituencies in country-bd.csv

Can you please add a README to the BD directory for context ?

@GoogleCivics-Kantar
Copy link
Contributor Author

Hi @azuser

we have created separate file for electorates and added README file.

@GoogleCivics-Kantar GoogleCivics-Kantar changed the title Bangladesh OCDID Update OCDID Update Oct 11, 2023
@GoogleCivics-Kantar
Copy link
Contributor Author

Hi @azuser ,

we have renamed Papua Pengunungan to Papua Pegunungan in dewan_perwakilan_rakyat.csv,region.csv and country_id.csv.

@GoogleCivics-Kantar GoogleCivics-Kantar closed this by deleting the head repository Oct 11, 2023
@jloutsenhizer
Copy link
Contributor

@NaviThotlu did you meant to close this PR?

@GoogleCivics-Kantar
Copy link
Contributor Author

Hi @jloutsenhizer ,

we deleted the forked repository, that's why it got closed automatically, we didn't mean to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants