Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bangladesh OCDID Update #355

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Bangladesh OCDID Update #355

merged 8 commits into from
Oct 26, 2023

Conversation

GoogleCivics-Kantar
Copy link
Contributor

Hi @zohour,

  1. Added Bangladesh new constituencies in country-bd.csv
  2. Added Bangladesh new constituencies in Jatiya_Sangsad_electorates.csv
  3. Added README file.

@asmitajha91
Copy link

@azuser Hi Zohour, could you please help review this PR.

HKSenior
HKSenior requested changes Oct 23, 2023
View reviewed changes
identifiers/country-bd/Jatiya_Sangsad_electorates.csv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this wiki Jatiya Sangsad has 8 divisions. The following districts aren't represented within the additions, please add them:

  • Barishal of the Barisal district,
  • Jhalokati of the Barisal district
  • Moulivibazar of the Sylhet district

identifiers/country-bd/README Outdated
File contents in `country-bd` directory:

* Jatiya_Sangsad_electorates.csv:contains the list of electoral districts for the House of the Nation (Jatiya Sangsad) of Bangladesh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove new line from between list elements.

identifiers/country-bd/README Outdated
@@ -0,0 +1,9 @@
File contents in `country-bd` directory:

* Jatiya_Sangsad_electorates.csv:contains the list of electoral districts for the House of the Nation (Jatiya Sangsad) of Bangladesh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a space after the colon.

Suggested change
* Jatiya_Sangsad_electorates.csv:contains the list of electoral districts for the House of the Nation (Jatiya Sangsad) of Bangladesh
* Jatiya_Sangsad_electorates.csv: contains the list of electoral districts for the House of the Nation (Jatiya Sangsad) of Bangladesh

@GoogleCivics-Kantar
Copy link
Contributor Author

GoogleCivics-Kantar commented Oct 25, 2023 •
edited
Loading

Hi @HKSenior,

  1. We have updated Barisal to Barishal, but for Jhalokati and Moulivibazar we have checked those have names as Jhalokathi and Maulvibazar in the Bangladesh parliament website. Please refer to screen shot below.
    image002

image001

  1. we have updated README file with the changes mentioned.

HKSenior
HKSenior requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@HKSenior HKSenior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification on the previous divisions.

identifiers/country-bd/Jatiya_Sangsad_electorates.csv Outdated
ocd-division/country:bd/ed:rangamati,Rangamati
ocd-division/country:bd/ed:bandarban,Bandarban
ocd-division/country:bd/ed:khagrachari,Khagrachari
ocd-division/country:bd/ed:coxs_bazar_1,Cox s Bazar-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to have an apostrophe within the name column. Please add here and the following lines.

Suggested change
ocd-division/country:bd/ed:coxs_bazar_1,Cox s Bazar-1
ocd-division/country:bd/ed:coxs_bazar_1,Cox's Bazar-1

Screenshot from website:
Screenshot 2023-10-25 at 8 10 20 AM

@GoogleCivics-Kantar
Copy link
Contributor Author

Hi @HKSenior ,

we have added apostrophe in Cox's Bazar.

jloutsenhizer
jloutsenhizer approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jloutsenhizer jloutsenhizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick spot check, everything looks good to me.

jpmckinney
jpmckinney approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Makes sense to omit the division and district from the OCD-ID, and just keep the constituency. (I quickly compared to https://en.wikipedia.org/wiki/List_of_constituencies_of_the_Jatiya_Sangsad)

@jloutsenhizer jloutsenhizer merged commit 19b82f4 into opencivicdata:master Oct 26, 2023
1 check passed
@GoogleCivics-Kantar GoogleCivics-Kantar deleted the Branch_BD branch February 29, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HKSenior HKSenior HKSenior requested changes

@jloutsenhizer jloutsenhizer jloutsenhizer approved these changes

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GoogleCivics-Kantar @asmitajha91 @jpmckinney @jloutsenhizer @HKSenior