Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Constituencies of the House of Representatives election and European Parliament election for the Netherlands #357

Merged
merged 7 commits into from
Oct 27, 2023
Merged

add Constituencies of the House of Representatives election and European Parliament election for the Netherlands #357

merged 7 commits into from
Oct 27, 2023

Conversation

sguenther85
Copy link
Contributor

No description provided.

HKSenior
HKSenior requested changes Oct 23, 2023
View reviewed changes
identifiers/country-nl/electoral_districts.csv Outdated Show resolved Hide resolved
identifiers/country-nl/electoral_districts.csv Outdated Show resolved Hide resolved
identifiers/country-nl/electoral_districts.csv Outdated Show resolved Hide resolved
sguenther85 and others added 4 commits October 23, 2023 18:19
@sguenther85 @HKSenior
Update identifiers/country-nl/electoral_districts.csv
374cbae 
Co-authored-by: Hassani King Senior <hassanisnr@gmail.com>
@sguenther85 @HKSenior
Update identifiers/country-nl/electoral_districts.csv
3a68f0c 
Co-authored-by: Hassani King Senior <hassanisnr@gmail.com>
@sguenther85
Update electoral_districts.csv
bc847c4 
Trailing new line
@sguenther85
Update top_level.csv
f7848a9 
Trailing new line
@sguenther85
Copy link
Contributor Author

Does anyone know why the test / run failed?
And @jdmgoogle @jloutsenhizer maybe you can check the pull request. The election is at the end of November.

@jloutsenhizer
Copy link
Contributor

Going to the details link from the test/run gives the logs. It looks like compile.py needs to be rerun:

+ [] : The following countries must be recompiled to match their source files:
  nl

Please run the following commands to rebuild:
  ./scripts/compile.py nl

@sguenther85
Copy link
Contributor Author

@jloutsenhizer Thank you. Now I have seen it too. Through the commit suggestions there were differences between the source and the result file.

@sguenther85
Copy link
Contributor Author

@jloutsenhizer @azuser @jamesturk @HKSenior anybody able to review and merge?

jloutsenhizer
jloutsenhizer reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@jloutsenhizer jloutsenhizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall, I had a quick question concerning whether the IDs should use the district number of the name

identifiers/country-nl/electoral_districts.csv Show resolved Hide resolved
@jloutsenhizer jloutsenhizer merged commit 04d5e5d into opencivicdata:master Oct 27, 2023
1 check passed
@sguenther85 sguenther85 deleted the add_ocdid_netherlands branch December 14, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolasYo NikolasYo NikolasYo left review comments

@HKSenior HKSenior HKSenior requested changes

@jloutsenhizer jloutsenhizer jloutsenhizer approved these changes

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguenther85 @jloutsenhizer @jpmckinney @HKSenior @NikolasYo