-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
India - Assam Lok Sabha OCDID Update #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a source you can share for the new districts? I went off of what was available on this Wikipedia article and based on that all of the district changes in Assam are renames, but based on this PR some are renames and some are replacements. Could you provide some clarification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source links are returning 404 for me.
It looks like these are ending:
- Autonomous District
- Kaliabor
- Mangaldoi
- Tezpur
And these are new:
- Darrang-Udalgiri
- Diphu
- Karizanga
- Sonitpur
Then gauhati and nowgong are being renamed. We should remove those two from lok_sabha and leave them only in aliases.
identifiers/country-in/lok_sabha.csv
Outdated
ocd-division/country:in/state:as/cd:nowgong,Assam Lok Sabha constituency Nowgong,, | ||
ocd-division/country:in/state:as/cd:silchar,Assam Lok Sabha constituency Silchar,, | ||
ocd-division/country:in/state:as/cd:tezpur,Assam Lok Sabha constituency Tezpur,, | ||
ocd-division/country:in/state:as/cd:silchar_sc,Assam Lok Sabha constituency Silchar (SC),, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think we shouldn't be adding silchar_sc. We don't add the (SC) as part of the ID in other cases. (We shouldn't add the alias either, if we remove it here.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @jpmckinney We have removed gauhati and nowgong from loksabha.csv & removed silchar_sc from both loksabha.csv and from alias.csv & have updated this changes in country-in.csv.
Hi Team, please see below points regarding the lok_sabha.csv
|
Hi Zohour,
This Pull Request contains below updated files for India - Assam Lok Sabha,