Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

India - Assam Lok Sabha OCDID Update #360

Merged
merged 14 commits into from
Feb 13, 2024

Conversation

mayanksahu123
Copy link
Contributor

@mayanksahu123 mayanksahu123 commented Dec 13, 2023

Hi Zohour,

This Pull Request contains below updated files for India - Assam Lok Sabha,

  1. Added Valid To dates to kaliabor & kaliabor in lok sabha.csv
  2. Added new constituency kaliabor & sonitpur in lok sabha.csv
  3. Renamed mangaldoi, gauhati, autonomous_district, karimganj, silchar, nowgong constituencies by adding new ocd id in in lok sabha.csv & also added them in alias.csv

@mayanksahu123 mayanksahu123 changed the title India - Assam Lok Sabha Changes India - Assam Lok Sabha OCDID Update Dec 13, 2023
Copy link
Contributor

@jloutsenhizer jloutsenhizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a source you can share for the new districts? I went off of what was available on this Wikipedia article and based on that all of the district changes in Assam are renames, but based on this PR some are renames and some are replacements. Could you provide some clarification?

identifiers/country-in/lok_sabha.csv Show resolved Hide resolved
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source links are returning 404 for me.

It looks like these are ending:

  • Autonomous District
  • Kaliabor
  • Mangaldoi
  • Tezpur

And these are new:

  • Darrang-Udalgiri
  • Diphu
  • Karizanga
  • Sonitpur

Then gauhati and nowgong are being renamed. We should remove those two from lok_sabha and leave them only in aliases.

ocd-division/country:in/state:as/cd:nowgong,Assam Lok Sabha constituency Nowgong,,
ocd-division/country:in/state:as/cd:silchar,Assam Lok Sabha constituency Silchar,,
ocd-division/country:in/state:as/cd:tezpur,Assam Lok Sabha constituency Tezpur,,
ocd-division/country:in/state:as/cd:silchar_sc,Assam Lok Sabha constituency Silchar (SC),,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think we shouldn't be adding silchar_sc. We don't add the (SC) as part of the ID in other cases. (We shouldn't add the alias either, if we remove it here.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @jpmckinney We have removed gauhati and nowgong from loksabha.csv & removed silchar_sc from both loksabha.csv and from alias.csv & have updated this changes in country-in.csv.

@jloutsenhizer jloutsenhizer merged commit 693410c into opencivicdata:master Feb 13, 2024
1 check passed
@raghu1061998
Copy link
Contributor

Hi Team, please see below points regarding the lok_sabha.csv

  • Name change: - The name of Anantnag constituency is changed to Anantnag-Rajouri. The current OCD ID ‘ocd-division/country:in/territory:jk/cd:Anantnag’ shows the name as ‘Jammu and Kashmir Lok Sabha constituency Anantnag’ in the repository, need to be changed to ‘Jammu and Kashmir Lok Sabha constituency Anantnag-Rajouri’.

  • Ladakh: - The present OCD ID of Ladakh Constituency ‘ocd-division/country:in/territory:jk/cd:ladakh’ shows the name as ‘Jammu and Kashmir Lok Sabha constituency Ladakh’. Ladakh is a separate UT now and hence, it should be ‘Ladakh Lok Sabha constituency Ladakh’. (Looks like the territory was updated but it still remains under JK instead of LA)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants