Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ottawa divisions #386

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

rafe-murray
Copy link
Contributor

This PR update the division names of six of Ottawa's existing wards and adds one new ward in order to match the changes made in 2022 documented on this page

Copy link
Contributor

@evannjw evannjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider keeping the old district ids and adding a validThrough date on them then alias those ids to the new ones you're adding. Will defer to @jpmckinney here.

@rafe-murray
Copy link
Contributor Author

I tried doing this on my machine, but I got an error when I tried to run the compile script due to not actually changing the id's, just the names of the districts.

@jpmckinney
Copy link
Member

The approach for the municipal level is to update shapefiles in https://github.com/opennorth/represent-canada-data and then regenerate OCID-IDs based on that. Maintaining history at the municipal level is not really feasible.

https://open.ottawa.ca/datasets/ottawa::wards-2022-2026/explore?location=45.245954%2C-75.801100%2C0.96&showTable=true

Copy link
Contributor

@evannjw evannjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me.

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the shapefile and they correspond to this PR.

@jpmckinney jpmckinney merged commit 32eb159 into opencivicdata:master Jun 13, 2024
1 check passed
@jpmckinney jpmckinney added the CA label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants