Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump std #193

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Bump std #193

merged 1 commit into from
Mar 20, 2024

Conversation

tobiasgrosser
Copy link
Collaborator

@tobiasgrosser tobiasgrosser commented Mar 6, 2024

The main differences to fix are:

  • simp became less aggressive and we have to use zetaDelta := true to obtain the original behavior
  • generalize unfolds less and we introduce our own generalize! to keep the old behavior
  • BitVec moved to lean4 itself and the definition of BitVec.ofInt changed
  • Mathlib's library search changed, so we drop it for now
  • The syntax became less permissive in case of broken indentation. We consequently fix our indentation.

@tobiasgrosser
Copy link
Collaborator Author

This PR has still two unfinished sorries.

@tobiasgrosser
Copy link
Collaborator Author

The following tasks are still open:

one BitVec proof does not go through, due to casts

   -- rw [xxx] -- This should go through, but does not due to casting issues.
        have yy : 2 ^ w - 1 < (2 ^ w + 1) / 2 := by sorry

Some of the BitVec proofs are rather verbose.

@tobiasgrosser
Copy link
Collaborator Author

I merged this as the deadline now has passed.

Merged via the queue into main with commit 94ee7a7 Mar 20, 2024
1 check passed
@tobiasgrosser tobiasgrosser deleted the bump_std branch March 20, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant