-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add example from paper for FHE. #237
Conversation
To clarify: the axiom trick is needed because of the reduction we do in the |
@alexkeizer that's right. |
@alexkeizer actually, on second thought, I think there are two places we agressively reduce: one is in |
@alexkeizer My hope is that the example is self-contained enough for someone (nudge nudge @tobiasgrosser ) to investigate if it's possible to eliminate the need for the axiom. |
Good to know: we could (should) change |
@alexkeizer that might, but I would not take my word for it. I'd have to play with the example again to remember precisely what caused me to need an |
I'd like to give it a try: reducing less aggressively seems like a win regardless of if it fixes this exact issue. EDIT: I've attempted my suggestion in #238, but it does not seem to solve all of the problems here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say this is fine to merge after you've addressed my (minor) comments
Co-authored-by: Alex Keizer <alex@keizer.dev>
Co-authored-by: Alex Keizer <alex@keizer.dev>
To make this example work, we need a definition of
R.ofZ
that is computable, and which is not agressively unfolded. This is ensured by ouraxiom
trick.Code peeled from pre-paper submission PR: #196.
Code stacked on: #234
Closes #196 (This PR fully integrates the features of #196 into main.)