Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handwritten-proof AndOrXor #263

Merged
merged 13 commits into from
Apr 30, 2024
Merged

feat: handwritten-proof AndOrXor #263

merged 13 commits into from
Apr 30, 2024

Conversation

tobiasgrosser
Copy link
Collaborator

This one is again pulled out from #167.

This one is again pulled out from #167.
@tobiasgrosser tobiasgrosser changed the title feat: handwrittten-proof AndOrXor feat: handwritten-proof AndOrXor Apr 29, 2024
@tobiasgrosser tobiasgrosser marked this pull request as ready for review April 29, 2024 23:39
@bollu
Copy link
Collaborator

bollu commented Apr 29, 2024

LGTM, I vaguely remember there being a nicer way to write:

rcases c1 with rfl | c1 <;> try (simp; done)

That is, the trivial case should be dealt with by simp, and the complex case with .some should not have the proof state be changed. Ping @alexkeizer / @goens for some post-merge cleanup!

@tobiasgrosser tobiasgrosser added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 9c618e7 Apr 30, 2024
1 check passed
@tobiasgrosser tobiasgrosser deleted the large_proofs_twoe branch April 30, 2024 00:10
@bollu bollu mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants