Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eliminate sequences of BitVec.ofBool #303

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

tobiasgrosser
Copy link
Collaborator

This solves one additional theorems and simplifies a number of theorems we are seeing. We are now at 50/93 solved statements.

@bollu
Copy link
Collaborator

bollu commented May 14, 2024

It’s a little unclear to me which side this rewrite should be written with for the normal form. As currently written, it attempts to “coalesce” adjacent ofBool bitvectors. I could very well see a case to be made for the opposite direction, where we want to break up bitvectors?

i wonder if we should have a custom simp-set rather than the default simp, then I’d be happy to allow this without a second thought.

@tobiasgrosser
Copy link
Collaborator Author

I am not sure it is worth proactively creating a simp-set here. I would rather add this now and then create a simp-set in case we need the other direction.

@bollu
Copy link
Collaborator

bollu commented May 20, 2024

I feel uncomfortable merging this in, since it adds simp lemmas to the global simp set. I'm happy with the following solutions:

  1. Build a dedicated simp set for alive and use it.
  2. Use aesop and see how that fares.

@tobiasgrosser
Copy link
Collaborator Author

@bollu, I created a dedicated simp-set. This reduces the unsolved lemma's to 39.

@bollu
Copy link
Collaborator

bollu commented May 23, 2024

Thanks!

@bollu bollu added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit fc64834 May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants