Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitvec_283 #327

Merged
merged 5 commits into from
May 22, 2024
Merged

bitvec_283 #327

merged 5 commits into from
May 22, 2024

Conversation

eurquhart1
Copy link
Contributor

@eurquhart1 eurquhart1 commented May 22, 2024

This resolves #306.

Copy link
Contributor Author

@eurquhart1 eurquhart1 May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure how I can fix this whitespace issue, any advice would be appreciated!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How nice. I fixed the newline issue in #329. This change should be merged in 15 minutes. You can then just execute git remote update; git merge origin/main and the issue should be resolved in your branch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this for you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you very much. I'll remember this for next time

Copy link
Collaborator

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you @eurquhart1 .

@tobiasgrosser tobiasgrosser marked this pull request as ready for review May 22, 2024 13:24
@tobiasgrosser tobiasgrosser added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 069ec67 May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm: multiplication equals boolean-and on 1-bit BitVectors - bitvec_283
2 participants