Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oom_get_cached_sff with length exceeding page boundary repeats same page #5

Open
donboll opened this issue Mar 14, 2018 · 0 comments
Open

Comments

@donboll
Copy link
Contributor

donboll commented Mar 14, 2018

oom_get_cached_sff will accept any length. If the length exceeds the end of the page, it will call itself recursively with the length reduced by the amount already read from the page cache. The recursion does not increment the page number, so the data will keep coming from the same page.

Note, length less than 0 should return an exception as an error.

Probably should just restrict length to be positive, and offset + length to be <= 128 (no crossing page boundaries)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant