New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider whether RIB callbacks should be async/channel writes. #217

Open

robshakir opened this issue Nov 9, 2023 · 0 comments

Contributor

robshakir commented Nov 9, 2023

Today, we make a callback to the post-change function in the RIB when an operation has completed, this is currently blocking.

As @alshabib rightly points out -- this could cause performance issues. We should consider one of two things:

calling the callback in a goroutine so that it doesn't block.
deprecating the callback approach, and rather just providing a channel that we write these events to that the consumer can listen on

robshakir mentioned this issue

Add support for Flush for IPv6, and server support. #214

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment