Skip to content

Commit

Permalink
Fix versions, ordering, remove default
Browse files Browse the repository at this point in the history
Fix version numbering, ordering of yang statements to pass
pyang --lint --strict, and remove default value for port priority
  • Loading branch information
marius-ore committed Aug 18, 2023
1 parent ac0e6b1 commit faad653
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
10 changes: 4 additions & 6 deletions release/models/interfaces/openconfig-if-aggregate.yang
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ module openconfig-if-aggregate {
description
"Model for managing aggregated (aka bundle, LAG) interfaces.";

oc-ext:openconfig-version "2.5.4";
oc-ext:openconfig-version "2.5.0";

revision "2023-08-15" {
description
"Deprecate ethernet interface's aggregate-id and move it into a separate
container for individual interface link aggregation parameters at
/interfaces/interface/ethernet/aggregation. Add port-priority to said
container";
reference "2.5.4";
reference "2.5.0";
}

revision "2022-06-28" {
Expand Down Expand Up @@ -210,10 +210,10 @@ module openconfig-if-aggregate {
belonging to a logical aggregate / LAG";

leaf aggregate-id {
status deprecated;
type leafref {
path "/oc-if:interfaces/oc-if:interface/oc-if:name";
}
status deprecated;
description
"Specify the logical aggregate interface to which
this interface belongs";
Expand All @@ -236,7 +236,6 @@ module openconfig-if-aggregate {

leaf port-priority {
type uint16;
default "32768";
description
"This interface's priority in its aggregate interface";
}
Expand All @@ -260,11 +259,10 @@ module openconfig-if-aggregate {
}

container state {
config false;
description
"Operational state for interface's aggregation parameters";

config false;

uses aggregation-ethernet-config;
}
}
Expand Down
4 changes: 2 additions & 2 deletions release/models/lacp/openconfig-lacp.yang
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ module openconfig-lacp {
managing aggregate interfaces. It works in conjunction with
the OpenConfig interfaces and aggregate interfaces models.";

oc-ext:openconfig-version "1.2.1";
oc-ext:openconfig-version "1.3.0";

revision "2023-08-15" {
description
"Add actor and partner port priority state.";
reference "1.2.1";
reference "1.3.0";
}

revision "2021-07-20" {
Expand Down

0 comments on commit faad653

Please sign in to comment.