Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gratuitous-arp-accepted and unsolicited-na-accepted #1120

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cagdasalagoz-arista
Copy link

@cagdasalagoz-arista cagdasalagoz-arista commented May 31, 2024

Change Scope

Two new boolean leaf values will be added to paths below,

  • interfaces/interface/subinterfaces/subinterface/ipv4/config/
  • interfaces/interface/subinterfaces/subinterface/ipv6/config/.

A. Yang tree for IPv4

/oc-if:interfaces/oc-if:interface/oc-if:subinterfaces/oc-if:subinterface:
    +--rw ipv4
       +--rw config
       |  +--rw enabled?                     boolean
       |  +--rw mtu?                         uint16
       |  +--rw dhcp-client?                 boolean
       |  +--rw gratuitous-arp-accepted?     boolean       <<<new
       +--ro state
          +--ro enabled?                     boolean
          +--ro mtu?                         uint16
          +--ro dhcp-client?                 boolean
          +--ro gratuitous-arp-accepted?     boolean       <<<new
          +--ro counters

B. Yang tree for IPv6

/oc-if:interfaces/oc-if:interface/oc-if:subinterfaces/oc-if:subinterface:
    +--rw ipv6
       +--rw config
       |  +--rw enabled?                     boolean
       |  +--rw mtu?                         uint32
       |  +--rw dup-addr-detect-transmits?   uint32
       |  +--rw dhcp-client?                 boolean
       |  +--rw unsolicited-na-accepted?     boolean    <<<new
       +--ro state
          +--ro enabled?                     boolean
          +--ro mtu?                         uint32
          +--ro dup-addr-detect-transmits?   uint32
          +--ro dhcp-client?                 boolean
          +--ro unsolicited-na-accepted?     boolean    <<<new
          +--ro counters

As the name suggests these will be used to toggle if the device will accept (and process) or reject the gratuitous arp updates.

This change is backwards compatible

Platform Implementations

A. Implementation for IPv4

Arista
command: arp gratuitous accept
doc: https://www.arista.com/en/um-eos/eos-ipv4#xx1397368

B. Implementation for IPv6

Arista
command: ipv6 nd na unsolicited accept
doc: https://www.arista.com/en/support/toi/eos-4-28-2f/16059-rfc9131-accepting-unsolicited-untracked-na

@cagdasalagoz-arista cagdasalagoz-arista requested a review from a team as a code owner May 31, 2024 11:07
Copy link

google-cla bot commented May 31, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dplore
Copy link
Member

dplore commented Jun 10, 2024

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Jun 10, 2024

No major YANG version changes in commit 9c1004d

@dplore
Copy link
Member

dplore commented Jun 10, 2024

Additional references

Cisco IOS XR - no arp gratuitous ignore

JunOS - set gratuitous-arp-reply

Nokia SR Linux - learn-unsolicited true

@wenovus
Copy link
Contributor

wenovus commented Jun 25, 2024

/gcbrun

1 similar comment
@wenovus
Copy link
Contributor

wenovus commented Jun 28, 2024

/gcbrun

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Small comment on updating the versioning and I think this is ready to go.

release/models/interfaces/openconfig-if-ip.yang Outdated Show resolved Hide resolved
release/models/interfaces/openconfig-if-ip.yang Outdated Show resolved Hide resolved
release/models/interfaces/openconfig-if-ip.yang Outdated Show resolved Hide resolved
@dplore
Copy link
Member

dplore commented Sep 24, 2024

/gcbrun

@dplore dplore self-assigned this Sep 24, 2024
@dplore dplore added the last-call PR that is in final review before merging. label Sep 24, 2024
@dplore
Copy link
Member

dplore commented Sep 24, 2024

Last call for comments. This will merge on Oct 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call PR that is in final review before merging. non-breaking
Projects
Status: last-call
Development

Successfully merging this pull request may close these issues.

5 participants