-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multicast counters to ip interface, remove physical counters from subinterface #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major YANG version changes in commit 7a7a74f: |
/gcbrun |
robshakir
requested changes
Jul 14, 2023
robshakir
reviewed
Jul 19, 2023
All comments addressed, let me know if you think it's ready @robshakir |
Thanks for the changes. LGTM. |
robshakir
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Scope
Platform Implementations
Error counters analysis
The TODO item to investigate if additional interface error counters are needed was removed based on the following analysis:
I'd like to complain a little bit that this is expanding the scope of the PR which is intended to be small and only seeks to
Thank you for reading my complaint. :)
That said, I investigated and I think this TODO can be removed. Here are the error counters which seem to match commonly supported output from 'show interfaces' commands on various implementations. There is variation by This varies by hardware and NOS. Some platforms report only input and output errors without support for additional, more granular errors. Some platforms aggregate errors as input and output errors and also support more granular errors.