Fix CI push and change pyangbind to run against its master branch as a compatibility report check #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No major YANG version changes in commit bf264a4 |
dplore
reviewed
Jul 13, 2023
|
Compatibility Report for commit bf264a4: |
wenovus
changed the title
|
@robshakir Are you ok with having pyangbind in the compat-report, or should we fix that first? |
robshakir
reviewed
Jul 14, 2023
| -branch=$BRANCH_NAME | ||
| -compat-report=pyangbind |
There was a problem hiding this comment.
Are we now making pyangbind non-blocking?
There was a problem hiding this comment.
There is an error in the BFD model: https://gist.github.com/OpenConfigBot/f2158a52bc907ed4e690582d47f2af61#gistcomment-4628801
I want to make it unblocking until we resolve it.
There was a problem hiding this comment.
Opened an issue in pyangbind: robshakir/pyangbind#302
wenovus
changed the title
wenovus
changed the title
dplore
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite PR: openconfig/models-ci#84