Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI push and change pyangbind to run against its master branch as a compatibility report check #912

Merged
merged 14 commits into from
Jul 17, 2023
Merged

Fix CI push and change pyangbind to run against its master branch as a compatibility report check #912

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1dcc2a5
Fix CI push and increase timeout
wenovus Jul 13, 2023
9c501dd
remove yanglint comment
wenovus Jul 13, 2023
d2e6fb1
Test with new pyangbind plugin dir
wenovus Jul 14, 2023
475954e
Trigger Build
wenovus Jul 14, 2023
bca3526
revert timeout increase
wenovus Jul 14, 2023
7003096
Trigger Build
wenovus Jul 14, 2023
37ad0ca
Trigger Build
wenovus Jul 14, 2023
ff380a5
Trigger Build
wenovus Jul 14, 2023
cb97bd1
Move pyangbind to compat report due to failing BFD check
wenovus Jul 14, 2023
2133712
Update to v10 for CI
wenovus Jul 14, 2023
662e071
Test new pyangbind version
wenovus Jul 14, 2023
46ef618
trigger CI
wenovus Jul 14, 2023
57f0b65
Trigger Build
wenovus Jul 14, 2023
bf264a4
Ready for review
wenovus Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ steps:
git clone git@github.com:openconfig/models-ci.git /go/src/github.com/openconfig/models-ci
cd /go/src/github.com/openconfig/models-ci
# Modify the major version to update models-ci version.
branch=$(git tag -l 'v9*' | sort -V | tail -1)
branch=$(git tag -l 'v10.*' | sort -V | tail -1)
git checkout $branch
volumes:
- name: 'ssh'
Expand Down Expand Up @@ -89,8 +89,8 @@ steps:
-pr-number=$_PR_NUMBER
-skipped-validators=confd,yanglint
-extra-pyang-versions=2.2.1
#-compat-report=yanglint
-branch=$BRANCH_NAME
-compat-report=pyangbind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we now making pyangbind non-blocking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error in the BFD model: https://gist.github.com/OpenConfigBot/f2158a52bc907ed4e690582d47f2af61#gistcomment-4628801

I want to make it unblocking until we resolve it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue in pyangbind: robshakir/pyangbind#302

secretEnv: ['GITHUB_ACCESS_TOKEN']
env:
- 'GOPATH=/go'
Expand Down
Loading