Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSPF summary-lsa metric #916

Merged
merged 15 commits into from
Aug 26, 2023
Merged

Add OSPF summary-lsa metric #916

merged 15 commits into from
Aug 26, 2023

Conversation

dplore
Copy link
Member

@dplore dplore commented Jul 17, 2023 •
edited
Loading

Change Scope

Add
/network-instances/network-instance/protocols/protocol/ospfv2/areas/area/lsdb/lsa-types/lsa-type/lsas/lsa/summary-lsa/state/metric

  • OSPF summary LSA contains a metric field, but the OC model is missing this.
  • This change is backwards compatible.

Platform Implementations

Tree view

        |     +--rw ospfv2
        |     |  +--rw areas
        |     |     +--rw area* [identifier]
        |     |        +--ro lsdb
        |     |        |  +--ro lsa-types
        |     |        |     +--ro lsa-type* [type]
        |     |        |        +--ro lsas
        |     |        |           +--ro lsa* [link-state-id]
        |     |        |              +--ro summary-lsa
        |     |        |              |  +--ro state
        |     |        |              |  |  +--ro network-mask?   uint8
        |     |        |              |  |  +--ro metric?         oc-ospf-types:ospf-metric      <-- added
        |     |        |              |  +--ro types-of-service
        |     |        |              |     +--ro type-of-service* [tos]
        |     |        |              |        +--ro tos      -> ../state/tos
        |     |        |              |        +--ro state
        |     |        |              |           +--ro tos?      uint8
        |     |        |              |           +--ro metric?   oc-ospf-types:ospf-metric

Fixes #915

@OpenConfigBot
Copy link

OpenConfigBot commented Jul 17, 2023 •
edited
Loading

Major YANG version changes in commit 78e15bd:

@dplore dplore mentioned this pull request Jul 17, 2023
Closed
@dplore dplore marked this pull request as ready for review July 17, 2023 23:43
@dplore dplore requested a review from a team as a code owner July 17, 2023 23:43
robshakir
robshakir requested changes Jul 19, 2023
View reviewed changes
release/models/bgp/openconfig-bgp-errors.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-types.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-types.yang Outdated Show resolved Hide resolved
release/models/ospf/openconfig-ospfv2-area-interface.yang Outdated Show resolved Hide resolved
release/models/ospf/openconfig-ospfv2-area.yang Outdated Show resolved Hide resolved
release/models/ospf/openconfig-ospfv2-global.yang Outdated Show resolved Hide resolved
release/models/ospf/openconfig-ospfv2-lsdb.yang Outdated Show resolved Hide resolved
release/models/ospf/openconfig-ospfv2-lsdb.yang Outdated Show resolved Hide resolved
release/models/ospf/openconfig-ospfv2-lsdb.yang Outdated Show resolved Hide resolved
release/models/ospf/openconfig-ospfv2.yang Outdated Show resolved Hide resolved
@OpenConfigBot
Copy link

OpenConfigBot commented Jul 20, 2023 •
edited
Loading

Compatibility Report for commit 78e15bd:
✅ pyangbind@6b85c2b

@dplore dplore requested a review from robshakir July 20, 2023 17:53
@dplore
Copy link
Member Author

dplore commented Jul 20, 2023

Ready for review

@dplore
Copy link
Member Author

dplore commented Aug 1, 2023

Thanks for the earlier review @robshakir, please take a look at the latest.

@dplore dplore added the last-call PR that is in final review before merging. label Aug 8, 2023
@dplore
Copy link
Member Author

dplore commented Aug 8, 2023

Set last call for Aug 22

@dplore
Copy link
Member Author

dplore commented Aug 22, 2023

/gcbrun

@dplore dplore requested a review from aashaikh as a code owner August 26, 2023 00:40
@dplore dplore merged commit b75925a into master Aug 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robshakir robshakir robshakir approved these changes

@aashaikh aashaikh Awaiting requested review from aashaikh aashaikh is a code owner

Assignees

@robshakir robshakir

Labels
last-call PR that is in final review before merging. non-breaking
Projects
OC Operator Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing link metric in ospfv2 summary-lsa model
3 participants
@dplore @OpenConfigBot @robshakir