Add config and state for individual Ethernet port priority in a LAG

[marius-ore]

Change Scope

• Add port-priority config and state for Ethernet interface that is part of a logical aggregation / LAG
• Add /lacp/interfaces/interface/members/member/state/partner-port-priority
• This change is not backwards compatible due to breaking change of changing type for list.

Platform Implementations

• Arista, section "Configuring Port Priority": https://www.arista.com/en/um-eos/eos-port-channels-and-lacp
• Cisco, section "Configuring the LACP System ID and Port Priority": https://www.cisco.com/c/en/us/td/docs/ios/12_2sb/feature/guide/gigeth.html
• JunOS: https://www.juniper.net/documentation/us/en/software/junos/interfaces-ethernet/topics/ref/statement/port-priority-edit-interfaces.html

Tree view

module: openconfig-lacp
  +--rw lacp
     +--rw config
     |  +--rw system-priority?   uint16
     +--ro state
     |  +--ro system-priority?   uint16
     +--rw interfaces
        +--rw interface* [name]
           +--rw name       -> ../config/name
           +--rw config
           |  +--rw name?              oc-if:base-interface-ref
           |  +--rw interval?          lacp-period-type
           |  +--rw lacp-mode?         lacp-activity-type
           |  +--rw system-id-mac?     oc-yang:mac-address
           |  +--rw system-priority?   uint16
           +--ro state
           |  +--ro name?              oc-if:base-interface-ref
           |  +--ro interval?          lacp-period-type
           |  +--ro lacp-mode?         lacp-activity-type
           |  +--ro system-id-mac?     oc-yang:mac-address
           |  +--ro system-priority?   uint16
           +--rw members
              +--rw member* [interface]
                 +--rw interface    -> ../config/interface                          <-- changed
                 +--rw config                                                              <-- new
                 |  +--rw interface?       oc-if:base-interface-ref.            <-- new
                 |  +--rw port-priority?   uint16                                <-- new
                 +--ro state
                    +--ro interface?               oc-if:base-interface-ref
                    +--ro port-priority?           uint16
                    +--ro activity?                lacp-activity-type
                    +--ro timeout?                 lacp-timeout-type
                    +--ro synchronization?         lacp-synchronization-type
                    +--ro aggregatable?            boolean
                    +--ro collecting?              boolean
                    +--ro distributing?            boolean
                    +--ro system-id?               oc-yang:mac-address
                    +--ro oper-key?                uint16
                    +--ro partner-id?              oc-yang:mac-address
                    +--ro partner-key?             uint16
                    +--ro port-num?                uint16
                    +--ro partner-port-num?        uint16                                    <-- new
                    +--ro partner-port-priority?   uint16
                    +--ro last-change?             oc-types:timeticks64
                    +--ro counters
                       +--ro lacp-in-pkts?               oc-yang:counter64
                       +--ro lacp-out-pkts?              oc-yang:counter64
                       +--ro lacp-rx-errors?             oc-yang:counter64
                       +--ro lacp-tx-errors?             oc-yang:counter64
                       +--ro lacp-unknown-errors?        oc-yang:counter64
                       +--ro lacp-errors?                oc-yang:counter64
                       +--ro lacp-timeout-transitions?   oc-yang:counter64

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[OpenConfigBot]

Major YANG version changes in commit 42ff19a:
openconfig-lacp.yang: 1.2.0 -> 2.0.0

[OpenConfigBot]

Compatibility Report for commit e86f152:
✅ pyangbind@6b85c2b

[marius-ore]

I think I've completed all the changes suggested so far. Any other feedback, or is the code good to merge?

[dplore]

I added the tree view to the description for the PR.

Summary of what was added:

module: openconfig-lacp
+--rw lacp
+--rw interfaces
+--rw interface* [name]
+--rw members
+--rw member* [interface]
+--rw interface -> ../config/interface
+--rw config
| +--rw port-priority? uint16
+--ro state
+--ro partner-port-priority? uint16

[dplore]

LGTM, last call for this change

[dplore]

Note, this is considered a breaking change because the list key for members was changed to point at the new config/interface leaf instead of the prior state/interface leaf.

[dplore]

Since this is now a non-breaking change, I've suggested a new, minor version number increment

[dplore]

@robshakir for your review

[robshakir]

LGTM, one indentation issue and then I think that this is a backwards incompatible change (as discussed with @dplore).