Added UnmarshalOpt to allow a best effort unmarshal #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hal still will not pass, but now the unmarshal will continue, logging any errors it encounters instead of exiting immediately.
wenovus
reviewed
Jun 7, 2023
wenovus
requested changes
Jun 14, 2023
wenovus
reviewed
Jun 15, 2023
… into best_effort_unmarshal
wenovus
requested changes
Jun 20, 2023
wenovus
reviewed
Jun 22, 2023
wenovus
requested changes
Jun 22, 2023
…ror string when BestEffortUnmarshal is passed.
|
Sorry, thought I had run gofmt, but forgot to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to allow a failing unmarshal will now pass - instead of failing, it will simply log the errors and continue the unmarshaling process. This is so that we can generate diffs for the entirety of the SetRequest, even if there's a compliance error.