Fix for python bytes-to-utf-8 encoded string in the usernames #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coweb+tornado==3.x, only minimally tested with tornado 2.x and tornado 3.1.1 on python 3.3.2 and opencoweb HEAD
| @@ -231,7 +231,7 @@ class SessionConnection(bayeux.BayeuxConnection): | |||
| '''Connection for uncollaborative sessions.''' | |||
| def on_auth_ext(self, cl, auth): | |||
| '''Overrides to use cookie + db for Bayeux authentication.''' | |||
| username = self._handler.current_user | |||
| username = self._handler.current_user.decode('utf-8') | |||
There was a problem hiding this comment.
This edit may not add/remove anything as the session worked identically for me with or without the change
There was a problem hiding this comment.
The username variable appears to not be used if you follow the function calls. But, your change is correct; this was an oversight related to python2/3 and the new version of Tornado conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the session join problem #236 that the >1 client has with opencoweb+tornado>=3.x, this is only minimally tested with tornado 2.x and tornado 3.1.1 on python 3.3.2 and OCW 5822afa