Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use NATIONAL_ID so it can be searched with #2

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

naftis
Copy link

@naftis naftis commented Dec 19, 2024

Instead of the BIRTH_CONFIGURABLE_IDENTIFIER, lets use NATIONAL_ID so it supports searching by default. IMO this is not ideal as we need custom mapping country-config code, but Events V2 should address this via allowing configuring what can be searched with.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Copy link
Collaborator

@tahmidrahman-dsi tahmidrahman-dsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@naftis naftis requested a review from euanmillar December 19, 2024 06:09
@naftis naftis merged commit 1c30892 into develop Dec 19, 2024
2 checks passed
@naftis naftis deleted the use-national-id-instead-of-configurable-identifier branch December 19, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants