Merge pull request #176 from VedantMahabaleshwarkar/update_manifests

update odh-model-controller manifests
opendatahub-io · Aug 30, 2023 · 39ef635 · 39ef635
2 parents 2961acd + 238c0e4
commit 39ef635
Show file tree

Hide file tree

Showing 6 changed files with 446 additions and 354 deletions.
diff --git a/opendatahub/odh-manifests/model-mesh/odh-model-controller/default/kustomization.yaml b/opendatahub/odh-manifests/model-mesh/odh-model-controller/default/kustomization.yaml
@@ -1,3 +1,3 @@
 bases:
   - ../rbac
-  - ../manager
+  - ../manager
diff --git a/...ests/model-mesh/odh-model-controller/overlays/odh/odh_model_controller_manager_patch.yaml b/...ests/model-mesh/odh-model-controller/overlays/odh/odh_model_controller_manager_patch.yaml
@@ -11,6 +11,11 @@ spec:
             - --leader-elect
             - "--monitoring-namespace"
             - "$(MONITORING_NS)"
+#This is hardcoded to be false in the overlay to model-mesh. 
+# Once Kserve and Modelmesh CRD conflict is resolved and both components can be installed together, 
+# ODH Model Controller will not be deployed as a overlay anymore and will be deployed only as an independent component. 
+# When that happens, the "kserve-enabled" flag needs to be removed
+            - --kserve-enabled=false            
           image: $(odh-model-controller)
           env:
             - name: MONITORING_NS