Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sklearn and tensorflow notebooks #119

Closed
wants to merge 4 commits into from

Conversation

mholder6
Copy link

@mholder6 mholder6 commented Jun 22, 2023

##Description
Added the sklearn-mnist JupyterNotebook model to the QuickStart as a sample model to guide users on how to deploy a model by using a Persistent Volume Claim(PVC).

Motivation

Modifications

Result

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally
  • If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

Hi @mholder6. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mholder6 mholder6 marked this pull request as ready for review June 26, 2023 17:43
Copy link
Author

@mholder6 mholder6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure the models work as expected

Copy link

@VedantMahabaleshwarkar VedantMahabaleshwarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mholder6 please clear the cell outputs from the notebook before committing

@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mholder6
Once this PR has been reviewed and has the lgtm label, please ask for approval from vedantmahabaleshwarkar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mholder6 mholder6 changed the title adding sklearn notebook added sklearn and tensorflow notebooks Jun 26, 2023
@mholder6 mholder6 linked an issue Jun 28, 2023 that may be closed by this pull request
@mholder6 mholder6 linked an issue Jul 13, 2023 that may be closed by this pull request
@spolti
Copy link
Member

spolti commented May 17, 2024

closing since there is no interaction in this PR, if you still need to have this contribution added, feel free to reopen it.

Thanks.

@spolti spolti closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants