ose-oauth-proxy image unified to be based on v4.10 tag

[shalberd]

Motivation

Make ose-oauth-proxy container version or sha256 digest reference consistent across all components e.g. odh-dashboard.

Will update in all places affected.

https://github.com/search?q=repo%3Aopendatahub-io%2Fmodelmesh-serving%20ose-oauth-proxy&type=code

Related to PR in odh-manifests to unify image opendatahub-io/odh-manifests#869

Agree on v4.10

registry.redhat.io/openshift4/ose-oauth-proxy@sha256:ab112105ac37352a2a4916a39d6736f5db6ab4c29bad4467de8d613e80e9bb33

Since ose-oauth-proxy tag reference image behind, the digest, regardless which openshift 4 minor version, changes regularly. Thus, and to be compatible with restricted network environment ImageContentSourcePolicy as well with node image caching with imagePullPolicy: IfNotPresent, change to digest notation.

Latest manifest link digest for v4.10 from July 6 2023

https://catalog.redhat.com/software/containers/openshift4/ose-oauth-proxy/5cdb2133bed8bd5717d5ae64?architecture=amd64&tag=v4.10.0-202306170106.p0.g799d414.assembly.stream&push_date=1688610772000&container-tabs=gti

included in this PR.

alternative way with downloading, just to show it is in fact the most current v4.10 digest:

docker pull registry.redhat.io/openshift4/ose-oauth-proxy:v4.10
v4.10: Pulling from openshift4/ose-oauth-proxy
1df162fae087: Already exists 
d20a374ee8f7: Already exists 
e88a8f7a57fc: Pull complete 
dcbbfecd111e: Pull complete 
Digest: sha256:ab112105ac37352a2a4916a39d6736f5db6ab4c29bad4467de8d613e80e9bb33
Status: Downloaded newer image for registry.redhat.io/openshift4/ose-oauth-proxy:v4.10
registry.redhat.io/openshift4/ose-oauth-proxy:v4.10

Modifications

different digest in template

Result

same image for ose-oauth-proxy as in all other components

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

• Unit tests pass locally
• FVT tests pass locally
• If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

• Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shalberd
Once this PR has been reviewed and has the lgtm label, please assign jooho for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @shalberd. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shalberd]

@anishasthana @Jooho in the base repo, there is an error, invalid yaml

https://github.com/opendatahub-io/modelmesh-serving/blob/main/.github/workflows/fvt.yml#L112

That happended during latest upstream sync

leading to this PR error

https://github.com/opendatahub-io/modelmesh-serving/actions/runs/5682570463

Shall I fix it along with this PR or do you? You probably know better what the right content should be.
Created an issue for it #151

[shalberd]

@LaVLaS @VaishnaviHire would putting ose-oauth-proxy version in kustomization.yaml images section be better than directly putting it in templates and so on? In terms of later better support for disconnected operator installs.

https://github.com/search?q=repo%3Aopendatahub-io%2Fmodelmesh-serving%20ose-oauth-proxy&type=code

similar to how it's done in odh-dashboard

https://github.com/opendatahub-io/odh-dashboard/blob/main/manifests/base/kustomization.yaml#L28

[spolti]

does this change still relevant?

f.y.i @israel-hdez @Jooho

[israel-hdez]

Following up on: https://issues.redhat.com/browse/RHOAIENG-2137