Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/home design 2024 #574

Merged
merged 101 commits into from
Nov 18, 2024
Merged

Feat/home design 2024 #574

merged 101 commits into from
Nov 18, 2024

Conversation

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit b60fe13
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/673b03a0d6c7d700086371e5
😎 Deploy Preview https://deploy-preview-574--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for meteo-france ready!

Name Link
🔨 Latest commit b60fe13
🔍 Latest deploy log https://app.netlify.com/sites/meteo-france/deploys/673b03a09b5fa7000822d122
😎 Deploy Preview https://deploy-preview-574--meteo-france.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@at-github at-github requested a review from abulte November 14, 2024 10:32
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un tout petit dernier retour et on devrait être bon 🚀

src/components/SearchComponent.vue Outdated Show resolved Hide resolved
@at-github at-github requested a review from abulte November 14, 2024 10:56
abulte
abulte previously approved these changes Nov 14, 2024
Copy link
Contributor

@narduin narduin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai surtout fait des petits retours de typo et d'ajustement, super taff sur cette home !

Dans le SearchComponent ligne 150 on a la règle css order: 1; qui à priori ne sert plus à rien.

src/custom/ecospheres/components/HomeFaq.vue Show resolved Hide resolved
src/custom/ecospheres/components/HomeFaq.vue Show resolved Hide resolved
src/custom/ecospheres/components/HomeFaq.vue Show resolved Hide resolved
src/custom/ecospheres/views/HomeView.vue Outdated Show resolved Hide resolved
src/custom/ecospheres/views/HomeView.vue Outdated Show resolved Hide resolved
src/custom/ecospheres/views/HomeView.vue Outdated Show resolved Hide resolved
src/custom/ecospheres/views/HomeView.vue Outdated Show resolved Hide resolved
@at-github at-github requested review from narduin and abulte November 14, 2024 15:15
@at-github at-github requested a review from abulte November 14, 2024 16:23
abulte
abulte previously approved these changes Nov 14, 2024
src/custom/ecospheres/components/HomeFaq.vue Outdated Show resolved Hide resolved
src/custom/ecospheres/components/HomeFaq.vue Outdated Show resolved Hide resolved
src/custom/ecospheres/components/HomeFaq.vue Outdated Show resolved Hide resolved
src/custom/ecospheres/components/HomeFaq.vue Outdated Show resolved Hide resolved
src/custom/ecospheres/views/HomeView.vue Outdated Show resolved Hide resolved
src/custom/ecospheres/views/HomeView.vue Outdated Show resolved Hide resolved
Copy link

@DanFluture275 DanFluture275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testé PO OK

@at-github at-github merged commit 4176292 into main Nov 18, 2024
7 checks passed
@at-github at-github deleted the feat/home-design-2024 branch November 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta ticket - Page d'accueil ecologie.data.gouv
4 participants