Fix spatial coverage not saved #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecospheres ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for meteo-france ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
abulte
reviewed
Nov 6, 2024
|
La couverture n'est pas pré-remplie quand on clique sur "éditer". J'ai résolu le problème autrement mais ce que tu as fait me semble propre à part ça. // bouquetForm.vue
// ligne 84
const onValidSubmit = async (validatedValues: {
[...]
topic.value.extras[topicsExtrasKey].subtheme = validatedValues.subtheme
+ onUpdateSpatialCoverage(spatialCoverage.value)
// sync valid status with parent
emits('updateValidation', true)
}
// ligne 247
- <SelectSpatialCoverage v-model="spatialCoverage" @update:model-value="onUpdateSpatialCoverage"/>
+ <SelectSpatialCoverage v-model:spatial-coverage-model="spatialCoverage" /> |
narduin
reviewed
Nov 6, 2024
abulte
reviewed
Nov 6, 2024
abulte
approved these changes
Nov 7, 2024
narduin
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ecolabdata/ecospheres#461