refactor document tree #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
force-pushed
the
refactor/document-tree
branch
from
d1ebbdc to
00a01e4
Compare
…into refactor/document-tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paradigm change of how we process documents. Before we only iterated through them and turned them into HTML on the fly. With this change we try to build a proper document tree (like DOM) which can then be used to walk through the document in any direction. The HTML generation is mostly unchanged. This can allow us to do proper editing in the future and provides better styling resolution.
The separation between public and private interface allows more flexibility in the backend while the frontend should be (hopefully) stable.
As a by-product this also contains now a HTML writer which supports some basic formatting. The hope is that this will reduce reference file diff size and makes it possible to spot differences in the HTML diff directly.