Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move get_args out of dataset_ui #51

Closed
mccalluc opened this issue Oct 8, 2024 · 0 comments · Fixed by #64
Closed

Move get_args out of dataset_ui #51

mccalluc opened this issue Oct 8, 2024 · 0 comments · Fixed by #64

Comments

@mccalluc
Copy link
Contributor

mccalluc commented Oct 8, 2024

There is still a call to get_args in dataset_server below, so I'm not sure that it would be much cleaner just to move one and not the other. I do wonder if there is some way the contributions input could get its default value from the server, but the default value isn't really something that is reacting to user input, so I don't see how that would work.

The right way to do this might be more clear to me with more familiarity with Shiny.

Originally posted by @mccalluc in #41 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant