Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only install Chromium #107

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Only install Chromium #107

merged 3 commits into from
Oct 31, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Oct 31, 2024 •
edited
Loading

  • Fix On CI, just download one browser? #20
  • CI download time might not be the most important thing to optimize: We could just drop this and close the issue. Thoughts?
  • Another option, and probably not necessary for us, would be to configure a matrix and confirm that different browsers work.

@mccalluc mccalluc marked this pull request as ready for review October 31, 2024 01:30
@ekraffmiller
Copy link
Member

I think Chrome has a much bigger user base, so maybe it is worth the extra download time, if we are only testing against one browser.

ekraffmiller
ekraffmiller reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below

@mccalluc mccalluc changed the title Only install FF Only install Chromium Oct 31, 2024
ekraffmiller
ekraffmiller approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved

@mccalluc mccalluc merged commit 3df19d6 into main Oct 31, 2024
2 checks passed
@mccalluc mccalluc deleted the 20-just-one-browser branch October 31, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekraffmiller ekraffmiller ekraffmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DP Wizard
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On CI, just download one browser?
2 participants
@mccalluc @ekraffmiller